fix(disk buffer): backpressure on runtime capacity errors - #26077
Draft
Jansen-w wants to merge 6 commits into
Draft
fix(disk buffer): backpressure on runtime capacity errors#26077Jansen-w wants to merge 6 commits into
Jansen-w wants to merge 6 commits into
Conversation
Jansen-w
force-pushed
the
fix/disk-buffer-enospc-backpressure
branch
from
August 26, 2026 17:28
abf82d6 to
95542cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Runtime filesystem capacity errors can be temporary, but disk-buffer writes previously treated them as fatal I/O failures. This change makes
disk_v2writers:StorageFull,ENOSPC, andEDQUOTerrors;when_fullbehavior while physical capacity exhaustion consistently backpressures every policy;Production writes remain session-owned synchronous syscalls. A kernel write cannot be portably cancelled and can delay cancellation until it returns; keeping it session-owned prevents writes from outliving the buffer lock or racing a reopened buffer.
Vector configuration
No new configuration is required. The behavior applies to existing
disk_v2buffers.How did you test this PR?
cargo test -p vector-buffers(132 passed, 2 pre-existing ignored)cargo clippy -p vector-buffers --all-targets -- -D warningscargo fmt --all -- --checkcargo vdev check eventscargo vdev check changelog-fragmentsReal exhausted-filesystem and Windows-specific behavior remain covered through deterministic fault injection rather than platform integration tests.
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
None.