Skip to content

fix(devtools): resolve ts7006 implicit-any bug #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vedanshshetti wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(devtools): resolve ts7006 implicit-any bug #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9068f73
chore: fix implicit-any error (ts7006) in unsubSelection
vedanshshetti Aug 31, 2026
a391cfd
chore: fix implicit-any error (ts7006) in unsubSelection (devtools-re…
vedanshshetti Aug 31, 2026
de6701d
chore: fix implicit-any error (ts7006) in unsubSelection (devtools-so…
vedanshshetti Aug 31, 2026
74c0746
Merge branch 'fix-internal' of https://github.com/vedanshshetti/jsonr…
vedanshshetti Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/devtools-react/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ export function JsonRenderDevtools(props: JsonRenderDevtoolsProps) {
handleRef.current = panel;

// Highlight in the host DOM as the selection changes.
const unsubSelection = selection.subscribe((key) => {
const unsubSelection = selection.subscribe((key: unknown) => {

@vercel vercel Bot Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const unsubSelection = selection.subscribe((key: unknown) => {
const unsubSelection = selection.subscribe((key) => {

Annotating the selection.subscribe callback parameter as (key: unknown) breaks the type-check because highlightElement requires a string, but unknown narrowed by if (key) becomes {}.

Fix on Vercel

if (key) highlightElement(key);
});

Expand Down
2 changes: 1 addition & 1 deletion packages/devtools-solid/src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export function JsonRenderDevtools(props: JsonRenderDevtoolsProps) {
reserveSpace: props.reserveSpace,
allowDockToggle: props.allowDockToggle,
});
unsubSelection = selection.subscribe((key) => {
unsubSelection = selection.subscribe((key: unknown) => {

@vercel vercel Bot Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unsubSelection = selection.subscribe((key: unknown) => {
unsubSelection = selection.subscribe((key) => {

selection.subscribe callback param typed (key: unknown) fails type-check because narrowed {} is not assignable to highlightElement's string parameter (TS2345)

Fix on Vercel

if (key) highlightElement(key);
});
releaseActive = markDevtoolsActive();
Expand Down