Skip to content

fix(ARC-3838):: handle 404 for non existant content page #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertyhell merged 1 commit into from
Aug 11, 2026
+6 −2
Merged

fix(ARC-3838):: handle 404 for non existant content page #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions api/src/modules/content-pages/controllers/content-pages.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,17 +113,21 @@ export class ContentPagesController {
): Promise<DbContentPage> {
try {
const user = sessionUser?.getUser();
return await this.contentPagesService.getContentPageByLanguageAndPathForUser(
const contentPage = await this.contentPagesService.getContentPageByLanguageAndPathForUser(
language || (user.language as Locale),
path,
user,
request?.headers?.Referrer as string,
ip,
onlyInfo === 'true'
);
if (!contentPage) {
throw new CustomError('ContentPage not found', null, {code: 'NOT_FOUND'}, 404);
}
return contentPage;
// biome-ignore lint/suspicious/noExplicitAny: error can be any type
} catch (err: any) {
if (err?.response?.additionalInfo?.code === 'NOT_FOUND') {
if (err?.response?.additionalInfo?.code === 'NOT_FOUND' || err?.statusCode === 404) {
throw new NotFoundException('The content page with path was not found');
}
const error = new CustomError('Failed to get content page by language and path', err, {
Expand Down