Skip to content

fix(ARC-3838): restore error message for content page failed to load #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bertyhell merged 1 commit into from
Aug 11, 2026
Merged

fix(ARC-3838): restore error message for content page failed to load #378

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/src/react-admin/modules/content-page/views/ContentPageDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ export const ContentPageDetail: FC<ContentPageDetailProps> = ({
<AdminLayout className={className} pageTitle={pageTitle}>
<AdminLayout.Back>
<Button type="borderless" onClick={onGoBack}>
<Icon name="chevronLeft"></Icon>
<Icon name="chevronLeft" />
</Button>
</AdminLayout.Back>
<AdminLayout.Actions>{renderContentActions()}</AdminLayout.Actions>
Expand Down
30 changes: 12 additions & 18 deletions ...min/modules/shared/components/LoadingErrorLoadedComponent/LoadingErrorLoadedComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import type { AvoAuthErrorActionButton } from '@viaa/avo2-types';
import type { FunctionComponent, ReactElement, ReactNode } from 'react';
import React from 'react';
import { CenteredSpinner } from '~shared/components/Spinner/CenteredSpinner';
import { tHtml } from '~shared/helpers/translation-functions';
import { tHtml, tText } from '~shared/helpers/translation-functions';
import ErrorView from '../error/ErrorView';

export type LoadingState = 'loading' | 'loaded' | 'error';

Expand Down Expand Up @@ -46,24 +47,17 @@ export const LoadingErrorLoadedComponent: FunctionComponent<LoadingErrorLoadedCo
locationId,
}) => {
const renderError = () => (
// <ErrorView
// message={
// loadingInfo.message ||
// t(
// 'shared/components/loading-error-loaded-component/loading-error-loaded-component___er-is-iets-mis-gegaan-bij-het-laden-van-de-gegevens'
// )
// }
// icon={loadingInfo.icon || 'alertTriangle' as IconName}
// actionButtons={loadingInfo.actionButtons || ['home']}
// />
<>
locationId: {locationId}
<br />
{loadingInfo.message ||
tHtml(
<ErrorView
message={
loadingInfo.message ||
tText(
'shared/components/loading-error-loaded-component/loading-error-loaded-component___er-is-iets-mis-gegaan-bij-het-laden-van-de-gegevens'
)}
</>
)
}
icon={loadingInfo.icon || ('alertTriangle' as IconName)}
actionButtons={loadingInfo.actionButtons || ['home']}
locationId={locationId}
/>
);

// Render
Expand Down