Skip to content

mail-react: Render nested Tip-Tap list items with their own style - #6459

Merged
VPS-Obi merged 4 commits into
mail-react/tip-tap-rich-text-blockfrom
mail-react/tip-tap-nested-list-styles
Oct 7, 2026
Merged

VPS-Obi merged 4 commits into
mail-react/tip-tap-rich-text-blockfrom
mail-react/tip-tap-nested-list-styles

Conversation

@VPS-Ricky

@VPS-Ricky VPS-Ricky commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

In the admin, a content editor can give a nested list item its own style, but the mail rendered the item with the style of the item around it. A nested list has no text component of its own, so its cells copied the text styles of the enclosing item, and the responsive rules of the outermost list reached the nested cells too.

A nested item without a style now gets its list's textBlocks style, not the style of the item around it, because the admin shows it that way too.

Screenshots/screencasts

The WithListVariants story of MjmlTipTapRichTextBlock:

Before Now
nested-list-before-desktop nested-list-after-desktop

Changeset

None needed: this fixes #6406, which is not released yet.


Task: https://vivid-planet.atlassian.net/browse/PHSB2C-12548

@VPS-Ricky VPS-Ricky self-assigned this Sep 28, 2026
@VPS-Ricky
VPS-Ricky added this pull request to stack #6460 September 28, 2026 14:10
@VPS-Ricky
VPS-Ricky force-pushed the mail-react/tip-tap-nested-list-styles branch 5 times, most recently from 675b929 to 6ad9e26 Compare October 1, 2026 10:08
@VPS-Ricky
VPS-Ricky marked this pull request as ready for review October 1, 2026 10:27
@VPS-Ricky

Copy link
Copy Markdown
Contributor Author

@greptileai

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Changes how nested list items render their text styles.

The PR appears safe to merge; no outstanding findings remain.

Summary

The PR makes nested Tip-Tap list items use their own text style, gives unstyled nested items their list’s default style, and scopes responsive text rules to individual rows. It also updates tests, examples, documentation, and the mail-react skill.

Reviews (3) · Last reviewed commit: "mail-react: Document the variant modifie..."

Comment thread packages/mail-react/src/blocks/richText/RichTextList.tsx
Comment thread packages/mail-react/src/blocks/richText/RichTextList.tsx
@VPS-Ricky
VPS-Ricky force-pushed the mail-react/tip-tap-nested-list-styles branch from 6ad9e26 to 5f10e00 Compare October 1, 2026 10:43
@VPS-Ricky

Copy link
Copy Markdown
Contributor Author

@greptileai

@VPS-Ricky

Copy link
Copy Markdown
Contributor Author

@greptileai

@VPS-Ricky
VPS-Ricky requested review from VPS-Obi and vps-manuel-blum and removed request for VPS-Obi and vps-manuel-blum October 1, 2026 10:56
VPS-Obi
VPS-Obi previously approved these changes Oct 6, 2026
@VPS-Andreas
VPS-Andreas force-pushed the mail-react/tip-tap-nested-list-styles branch from 5f10e00 to 20fef1e Compare October 7, 2026 08:01
A nested list has no text component of its own, so its cells copied
the text styles of the enclosing item, and the variant rules on the
outermost table reached the nested cells on mobile. Draft-js cannot
nest a list item with another style, so only Tip-Tap content showed it.
@VPS-Andreas
VPS-Andreas force-pushed the mail-react/tip-tap-nested-list-styles branch from 20fef1e to a224ead Compare October 7, 2026 08:12
@VPS-Andreas
VPS-Andreas requested a review from VPS-Obi October 7, 2026 08:21
@VPS-Andreas VPS-Andreas self-assigned this Oct 7, 2026
@VPS-Obi
VPS-Obi merged commit bb0c6c4 into main Oct 7, 2026
16 checks passed
@VPS-Obi
VPS-Obi deleted the mail-react/tip-tap-nested-list-styles branch October 7, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants