Repository navigation
Conversation
VPS-Ricky
added this pull request to stack #6460
September 28, 2026 14:10
VPS-Ricky
force-pushed
the
mail-react/tip-tap-nested-list-styles
branch
5 times, most recently
from
October 1, 2026 10:08
675b929 to
6ad9e26
Compare
VPS-Ricky
marked this pull request as ready for review
October 1, 2026 10:27
Contributor
Author
Contributor
|
VPS-Ricky
force-pushed
the
mail-react/tip-tap-nested-list-styles
branch
from
October 1, 2026 10:43
6ad9e26 to
5f10e00
Compare
Contributor
Author
Contributor
Author
VPS-Ricky
requested review from
VPS-Obi and
vps-manuel-blum
and removed request for
VPS-Obi and
vps-manuel-blum
October 1, 2026 10:56
VPS-Obi
previously approved these changes
Oct 6, 2026
VPS-Andreas
force-pushed
the
mail-react/tip-tap-nested-list-styles
branch
from
October 7, 2026 08:01
5f10e00 to
20fef1e
Compare
A nested list has no text component of its own, so its cells copied the text styles of the enclosing item, and the variant rules on the outermost table reached the nested cells on mobile. Draft-js cannot nest a list item with another style, so only Tip-Tap content showed it.
VPS-Andreas
force-pushed
the
mail-react/tip-tap-nested-list-styles
branch
from
October 7, 2026 08:12
20fef1e to
a224ead
Compare
VPS-Obi
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the admin, a content editor can give a nested list item its own style, but the mail rendered the item with the style of the item around it. A nested list has no text component of its own, so its cells copied the text styles of the enclosing item, and the responsive rules of the outermost list reached the nested cells too.
A nested item without a style now gets its list's
textBlocksstyle, not the style of the item around it, because the admin shows it that way too.Screenshots/screencasts
The
WithListVariantsstory ofMjmlTipTapRichTextBlock:Changeset
None needed: this fixes #6406, which is not released yet.
Task: https://vivid-planet.atlassian.net/browse/PHSB2C-12548