Skip to content

🐛 Preserve screenshot capture geometry#325

Closed
Robdel12 wants to merge 1 commit into
mainfrom
rd/preserve-capture-geometry
Closed

🐛 Preserve screenshot capture geometry#325
Robdel12 wants to merge 1 commit into
mainfrom
rd/preserve-capture-geometry

Conversation

@Robdel12

Copy link
Copy Markdown
Contributor

Why

The screenshot client accepted harness capture facts such as the coordinate mode, device scale factor, and element selector, but normalization dropped them before the cloud request. That left the API without the source facts it needs to build reliable screenshot identities or translate Honeydiff regions into CSS coordinates.

What changed

  • Preserve captureMode, deviceScaleFactor, and selector as reserved screenshot options in the cloud properties payload.
  • Promote the same fields from the legacy nested properties shape with the existing reserved-option warning behavior.
  • Document the public JavaScript and TypeScript contracts.
  • Cover the real request payload at the HTTP boundary.

Confidence

The full CLI suite passes (2,321 passing, 5 skipped), the production build completes, and the published type definitions pass their contract checks.

Keep harness-supplied coordinate facts in the cloud payload so the API can build reliable screenshot identities and region evidence without guessing.
@Robdel12

Copy link
Copy Markdown
Contributor Author

This browser-capture contract is superseded by the bitmap-native design. Vizzly must accept raw screenshots from any platform without requiring browser-specific capture metadata.

@Robdel12 Robdel12 closed this Jul 23, 2026
@Robdel12
Robdel12 deleted the rd/preserve-capture-geometry branch July 23, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant