Skip to content

fix(create): honor non-interactive mode in scaffolded generators - #2677

Merged
fengmk2 merged 2 commits into
voidzero-dev:mainfrom
SaKaNa-Y:fix/generator-non-interactive
Sep 13, 2026
Merged

fix(create): honor non-interactive mode in scaffolded generators#2677
fengmk2 merged 2 commits into
voidzero-dev:mainfrom
SaKaNa-Y:fix/generator-non-interactive

Conversation

@SaKaNa-Y

Copy link
Copy Markdown
Contributor

Running a scaffolded local generator with vp create <generator> --no-interactive still entered Bingo's prompts when required arguments were missing. With closed stdin, this exited with an unsettled top-level await instead of an actionable validation error. Bingo's --skip-requests flag does not disable prompts.

Pass VP_CREATE_INTERACTIVE to local Bingo generators. The starter uses Bingo's programmatic API in non-interactive mode, validates CLI arguments and required template options before generation, and rejects existing output directories. Interactive runs, help, and version requests retain the Bingo CLI path.

This applies to newly scaffolded generators. Existing copied entrypoints require an update, and custom template options need corresponding CLI argument declarations; the starter README documents both requirements.

Validation:

  • pnpm exec vitest run packages/cli/src/create/__tests__: 194 tests passed.
  • pnpm exec tsc --project packages/cli/templates/generator/tsconfig.json: passed.
  • cargo test -p vp_cli_snapshots -- create_generator_: both generator cases passed in comparison mode after recording and reviewing the updated snapshot.
  • Focused formatting and lint checks passed.

The regression covers missing arguments without prompts, no output directory on validation failure, preservation of existing files, successful file generation, and the interactive execution path. Validation was scoped to generator behavior; the full repository test suite was not run.

Pass the interaction mode to local Bingo generators and validate starter arguments before invoking the programmatic API. Preserve the interactive CLI path and document the update needed for existing generators.
@SaKaNa-Y
SaKaNa-Y marked this pull request as ready for review September 13, 2026 02:06
@fengmk2

fengmk2 commented Sep 13, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-13T05:50:21.599120Z de0c191 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fengmk2 fengmk2 self-assigned this Sep 13, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🎉

Reviewed commit: de0c191eff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@SaKaNa-Y

Copy link
Copy Markdown
Contributor Author

When --directory was provided without --name, Bingo created an empty directory before prompting for the missing name, leaving it behind when was closed.

@fengmk2 fengmk2 added test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: create-e2e Run `vp create` e2e tests test: sfw labels Sep 13, 2026
@fengmk2
fengmk2 merged commit ee90e39 into voidzero-dev:main Sep 13, 2026
114 of 143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test: create-e2e Run `vp create` e2e tests test: e2e Auto run e2e tests test: install-e2e run vite install e2e test test: sfw

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants