feat(installer): separate Node and package-manager preferences - #2681
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea29c6665c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97dca64005
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
The installer currently applies
VP_NODE_MANAGERto both Node.js and every package manager. This PR limits that environment variable to Node.js while preserving the existing combined installation prompt and its behavior.This PR adds
VP_PM_MANAGERto set the preference for all package managers, withVP_NPM_MANAGER,VP_PNPM_MANAGER,VP_YARN_MANAGER, andVP_BUN_MANAGERoverriding it for each family.yesselects Vite+ management;noselects system-first behavior. Explicit package-manager variables override the combined installer choice. With the script installers, a Node-only environment override preserves saved package-manager preferences. In-place upgrades keep existing settings.The
vp_installercrate keeps its existing options and forwards the resolved combined choice as bothVP_NODE_MANAGERand the default forVP_PM_MANAGER. Explicit package-manager overrides are preserved. Interactive and silent installations use the same forwarding logic.For example,
VP_NODE_MANAGER=no VP_PM_MANAGER=no VP_PNPM_MANAGER=yeskeeps Node.js and the other package managers system-first while letting Vite+ manage pnpm.🤖 Generated with Codex