Repository navigation
Conversation
This was referenced Oct 19, 2026
tee8z
added this pull request to stack #22
October 19, 2026 20:56
tee8z
force-pushed
the
dev-2884-reaper-checkpoint-evidence
branch
from
October 19, 2026 23:28
bc18c71 to
f7e8637
Compare
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
tee8z
force-pushed
the
dev-2884-reaper-checkpoint-evidence
branch
from
October 20, 2026 14:54
f7e8637 to
3f8cb15
Compare
tee8z
removed this pull request from stack #22
October 20, 2026 14:56
tee8z
added this pull request to stack #26
October 20, 2026 14:56
tee8z
force-pushed
the
dev-2884-reaper-checkpoint-evidence
branch
from
October 20, 2026 15:01
3f8cb15 to
d5b5efa
Compare
Collaborator
Author
|
@coderabbitai full review Please review the current revision against this PR’s immediate stack base. The descriptions document the remote-agent scope, regression coverage, and outstanding runtime validation. |
|
Add the reaper's checkpoint evidence module. It accepts a termination-log receipt or an inherited restore key only when the key sits under the session generation's prefix and an S3 ListObjectsV2 confirms it; an S3 outage defers the decision instead of recording a missing checkpoint. This brings in the AWS SDK dependencies and documents the checkpoint evidence rules in docs/remote-agents.md. Signed-off-by: Tee8z <tee8z@protonmail.com>
tee8z
force-pushed
the
dev-2884-reaper-checkpoint-evidence
branch
from
October 20, 2026 15:35
d5b5efa to
ac798e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tombstone must not record a checkpoint key that the Pod alone claims. This PR adds
src/evidence.rs, which confirms a key against an S3 (Amazon Simple Storage Service)ListObjectsV2of the session's own prefix. The prefix comes from the reaper config and the Sandbox annotations, never from the Pod. An S3 failure givesUnavailable, so the reaper postpones the decision instead of recordingmissing.flowchart TD receipt["from_receipt: agent container termination message"] --> own{"Receipt present, version 1, key directly under the session prefix?"} restore["inherited: restore-checkpoint annotation"] --> prev{"Key directly under the recovered-from prefix?"} own -- no --> missing["Missing"] prev -- no --> missing own -- yes --> list["CheckpointStore::contains: ListObjectsV2 of the prefix, max 10 pages"] prev -- yes --> list list -- "key found" --> found["Verified (receipt) or Inherited (restore key)"] list -- "key not found" --> missing list -- "S3 error or more than 10 pages" --> unavailable["Unavailable: decide on a later pass"]S3Storeuses onlyListObjectsV2(IAM permissions3:ListBucket). Connect, attempt, and operation timeouts are 5 s, 10 s, and 25 s.buzz_sandbox_reaper_s3_errors_total.docs/remote-agents.mdgets a "Checkpoint evidence" section that states these rules.Cargo.lock. Most of the lockfile growth is here.Stack
Position 16 of 21. Base: #18. Next: #20. Each PR contains one signed commit. #24 and #25 repair the fork’s existing CI prerequisites; the feature layers remain scoped to remote agents.
Validation
mesh-llm. Full localjust ciand the updated GitHub checks are in progress.Limits
Evidence tests use an in-memory store. Real S3 and workload credentials require deployment validation.
Human workflow confirmation is still required by AGENTS.md before readiness. Human acceptance has not been confirmed.