Skip to content

feat(cli): human output UX follow-ups - #19

Open
thebrandonlucas wants to merge 1 commit into
feat/cli-error-hintsfrom
feat/cli-ux-followups
Open

thebrandonlucas wants to merge 1 commit into
feat/cli-error-hintsfrom
feat/cli-ux-followups

Conversation

@thebrandonlucas

@thebrandonlucas thebrandonlucas commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Stack: master ← #20 ← #22 ← #24 ← this PR. Follow-ups raised while reviewing #5, #11, #14, and #15.

  • String lists: each item gets its own line in human output, aligned with the value column, so a dry run's notes no longer run together. An empty list shows as -.
  • voltage context shows auth_url beside api_url: the --auth-url flag, else the URL the selected login was saved with (sourced like the credential), else the built-in default.
  • Elapsed time on long waits: payment waits and device approval show the time waited so far, such as Waiting for completed... 1m 05s, so a slow wait does not look stuck.

Validation: cargo fmt --check, cargo clippy --locked --all-targets -- -D warnings, cargo machete --with-metadata, cargo test --locked (94 unit, 68 integration), and python3 scripts/check-coverage.py. A new terminal test checks the elapsed time on a payment wait; the context test checks auth_url and its source.

Base automatically changed from feat/cli-human-output to master October 9, 2026 20:11
@thebrandonlucas
thebrandonlucas changed the base branch from master to feat/cli-error-hints October 13, 2026 18:56
@thebrandonlucas
thebrandonlucas marked this pull request as ready for review October 13, 2026 18:56
@thebrandonlucas
thebrandonlucas added this pull request to stack #25 October 13, 2026 18:56
@thebrandonlucas
thebrandonlucas force-pushed the feat/cli-ux-followups branch 3 times, most recently from d0e7694 to 979d77b Compare October 19, 2026 13:47
@thebrandonlucas
thebrandonlucas force-pushed the feat/cli-ux-followups branch 2 times, most recently from 33b3ff1 to aaccd91 Compare October 19, 2026 18:39
Each item of a string list now gets its own line in human output, aligned
with the value column, so a dry run's notes no longer run together. An empty
list shows as -.

voltage context reports auth_url beside api_url: the --auth-url flag, else
the URL the selected login was saved with (sourced like the credential),
else the built-in default.

Payment waits and device approval show how long they have waited, such as
"Waiting for completed... 1m 05s", so a status line on a slow wait does not
look stuck.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant