vortex-datafusion: Pipe session through to converter#8591
Conversation
To be able to use #7824 in vortex-datafusion. Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
Merging this PR will improve performance by 21.26%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 215.3 ns | +27.1% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
333.9 ns | 275.6 ns | +21.17% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[2048] |
427.8 ns | 369.4 ns | +15.79% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing convert-session (f3542d3) with develop (15cec3b)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rationale for this change
To be able to use #7824 in vortex-datafusion.
What changes are included in this PR?
Piping it through and a test for UUID -> fixedsizebinary(16)
What APIs are changed? Are there any user-facing changes?
Default still has the same behavior, so while there is a new API, there's no change to existing users other than adhering to the session they already passed.