Skip to content

vortex-datafusion: Pipe session through to converter#8591

Merged
AdamGS merged 1 commit into
developfrom
convert-session
Jun 25, 2026
Merged

vortex-datafusion: Pipe session through to converter#8591
AdamGS merged 1 commit into
developfrom
convert-session

Conversation

@brancz

@brancz brancz commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

To be able to use #7824 in vortex-datafusion.

What changes are included in this PR?

Piping it through and a test for UUID -> fixedsizebinary(16)

What APIs are changed? Are there any user-facing changes?

Default still has the same behavior, so while there is a new API, there's no change to existing users other than adhering to the session they already passed.

To be able to use #7824 in vortex-datafusion.

Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
@brancz brancz requested a review from a team June 25, 2026 10:03
@AdamGS AdamGS added the changelog/fix A bug fix label Jun 25, 2026
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 21.26%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 1586 untouched benchmarks
⏩ 4 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 215.3 ns +27.1%
Simulation bitwise_not_vortex_buffer_mut[1024] 333.9 ns 275.6 ns +21.17%
Simulation bitwise_not_vortex_buffer_mut[2048] 427.8 ns 369.4 ns +15.79%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing convert-session (f3542d3) with develop (15cec3b)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS merged commit b4c85b6 into develop Jun 25, 2026
81 of 82 checks passed
@AdamGS AdamGS deleted the convert-session branch June 25, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants