Expand AWS session time for SQL benchmarks#8592
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | slice_empty_vortex |
310 ns | 368.3 ns | -15.84% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
273.6 ns | 244.4 ns | +11.93% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/expand-aws-session-time (3affefc) with develop (15cec3b)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Rationale for this change
Turns out nightly benchmarks were very close to the default token lifetime, but a few days ago they seemed to go over, so we should expand the token for a bit.
What changes are included in this PR?
Doubles the token duration for the sql-benchmarks flow.
What APIs are changed? Are there any user-facing changes?
N/A