Skip to content

Expand AWS session time for SQL benchmarks#8592

Merged
AdamGS merged 1 commit into
developfrom
adamg/expand-aws-session-time
Jun 25, 2026
Merged

Expand AWS session time for SQL benchmarks#8592
AdamGS merged 1 commit into
developfrom
adamg/expand-aws-session-time

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

Turns out nightly benchmarks were very close to the default token lifetime, but a few days ago they seemed to go over, so we should expand the token for a bit.

What changes are included in this PR?

Doubles the token duration for the sql-benchmarks flow.

What APIs are changed? Are there any user-facing changes?

N/A

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS requested review from a team and robert3005 June 25, 2026 10:06
@AdamGS AdamGS enabled auto-merge (squash) June 25, 2026 10:10
@AdamGS AdamGS merged commit 6fe605b into develop Jun 25, 2026
80 of 81 checks passed
@AdamGS AdamGS deleted the adamg/expand-aws-session-time branch June 25, 2026 10:14
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
❌ 1 regressed benchmark
✅ 1587 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation slice_empty_vortex 310 ns 368.3 ns -15.84%
Simulation bitwise_not_vortex_buffer_mut[128] 273.6 ns 244.4 ns +11.93%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/expand-aws-session-time (3affefc) with develop (15cec3b)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants