Skip to content

Guard calling is_nan on scalar value on dtype being a float#8593

Merged
robert3005 merged 3 commits into
developfrom
rk/isnan
Jun 25, 2026
Merged

Guard calling is_nan on scalar value on dtype being a float#8593
robert3005 merged 3 commits into
developfrom
rk/isnan

Conversation

@robert3005

Copy link
Copy Markdown
Contributor

Downcasting scalars is more expensive than checking dtypes

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 requested a review from a team June 25, 2026 11:20
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Jun 25, 2026
@robert3005 robert3005 enabled auto-merge (squash) June 25, 2026 11:26
@codspeed-hq

codspeed-hq Bot commented Jun 25, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 4 improved benchmarks
❌ 1 regressed benchmark
✅ 1584 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_into_canonical[(1000, 10)] 168.8 µs 205.6 µs -17.9%
Simulation chunked_varbinview_canonical_into[(100, 100)] 259.5 µs 224.5 µs +15.59%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.6 µs 271.4 µs +12.95%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/isnan (ef24d8f) with develop (b4c85b6)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@robert3005 robert3005 merged commit 937c9d7 into develop Jun 25, 2026
77 of 78 checks passed
@robert3005 robert3005 deleted the rk/isnan branch June 25, 2026 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants