Skip to content

move optimizer code to scalar_fn_pushdown#8605

Merged
myrrc merged 1 commit into
developfrom
myrrc/duckdb-move-optimizer
Jun 26, 2026
Merged

move optimizer code to scalar_fn_pushdown#8605
myrrc merged 1 commit into
developfrom
myrrc/duckdb-move-optimizer

Conversation

@myrrc

@myrrc myrrc commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This is preparatory work for aggregate pushdown

@myrrc myrrc requested review from a team and AdamGS June 26, 2026 16:19
@myrrc myrrc added the changelog/skip Do not list PR in the changelog label Jun 26, 2026
@myrrc myrrc enabled auto-merge (squash) June 26, 2026 16:20
@myrrc myrrc disabled auto-merge June 26, 2026 16:21
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/duckdb-move-optimizer branch from b46aa57 to 60ca692 Compare June 26, 2026 16:21
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
❌ 10 regressed benchmarks
✅ 1574 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation take_map[(0.1, 1.0)] 1.7 ms 2.4 ms -30.82%
Simulation take_map[(0.1, 0.5)] 983.2 µs 1,380.1 µs -28.76%
Simulation take_map[(0.01, 1.0)] 1.2 ms 1.6 ms -26.12%
Simulation take_map[(0.01, 0.1)] 161.1 µs 200 µs -19.44%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 155 µs 191.2 µs -18.94%
Simulation slice_empty_vortex 339.4 ns 397.8 ns -14.66%
Simulation take_map[(0.01, 0.05)] 106.3 µs 124.5 µs -14.65%
Simulation take_map[(0.01, 0.5)] 605.1 µs 703.3 µs -13.96%
Simulation take_map[(0.1, 0.1)] 456 µs 529.1 µs -13.81%
Simulation take_map[(0.005, 1.0)] 1.1 ms 1.3 ms -11.44%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 186.1 ns +31.34%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 246.4 ns +23.68%
Simulation bitwise_not_vortex_buffer_mut[2048] 398.6 ns 340.3 ns +17.14%
Simulation chunked_varbinview_canonical_into[(100, 100)] 259.8 µs 224.5 µs +15.73%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.3 µs 271.1 µs +12.98%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/duckdb-move-optimizer (60ca692) with develop (ba00e83)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc enabled auto-merge (squash) June 26, 2026 16:22
@myrrc myrrc merged commit 3451cb0 into develop Jun 26, 2026
66 checks passed
@myrrc myrrc deleted the myrrc/duckdb-move-optimizer branch June 26, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/skip Do not list PR in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants