Skip to content

Expose array buffer replacement#8606

Open
gatesn wants to merge 1 commit into
developfrom
ngates/with-buffers
Open

Expose array buffer replacement#8606
gatesn wants to merge 1 commit into
developfrom
ngates/with-buffers

Conversation

@gatesn

@gatesn gatesn commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Rationale for this change

I want to move array buffers between devices, but keep the same array tree.

@gatesn gatesn requested a review from a team June 26, 2026 16:41
Comment thread vortex-array/src/array/mod.rs Outdated
@codspeed-hq

codspeed-hq Bot commented Jun 26, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 10.55%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 1 regressed benchmark
✅ 1582 untouched benchmarks
⏩ 4 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_into_canonical[(1000, 10)] 168.8 µs 205.9 µs -17.98%
Simulation copy_nullable[65536] 1.4 ms 1 ms +32.08%
Simulation chunked_varbinview_canonical_into[(100, 100)] 259.6 µs 224.4 µs +15.68%
Simulation bitwise_not_vortex_buffer_mut[128] 215.3 ns 186.1 ns +15.67%
Simulation chunked_varbinview_into_canonical[(100, 100)] 306.5 µs 272.1 µs +12.65%
Simulation bitwise_not_vortex_buffer_mut[1024] 275.6 ns 246.4 ns +11.84%
Simulation eq_i64_constant 318.6 µs 288.3 µs +10.5%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing ngates/with-buffers (75dfba6) with develop (3451cb0)

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@gatesn gatesn force-pushed the ngates/with-buffers branch 2 times, most recently from d9b669d to 75dfba6 Compare June 26, 2026 17:19
@gatesn gatesn added the changelog/feature A new feature label Jun 26, 2026
Signed-off-by: "Nicholas Gates" <nick@nickgates.com>
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/with-buffers branch from 75dfba6 to 86443c3 Compare June 26, 2026 17:32
@gatesn gatesn enabled auto-merge (squash) June 26, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant