fix(AlertDialog): focus Cancel element on open per APG alertdialog pattern - #630
Open
sridhar-3009 wants to merge 5 commits into
Open
fix(AlertDialog): focus Cancel element on open per APG alertdialog pattern#630sridhar-3009 wants to merge 5 commits into
sridhar-3009 wants to merge 5 commits into
Conversation
…ttern (closes vuetifyjs#609) Register the Cancel element via onMounted/onUnmounted in AlertDialogCancel, store it on context, and call cancelEl.focus() whenever the dialog opens — matching the APG recommendation that alertdialog initial focus lands on the least-destructive action.
Contributor
|
✅ Changeset found — this change will be included in the next release. Thanks! |
Two branch/statement gaps left by codecov's patch-coverage check: - AlertDialogCancel.vue:63 — the cancelRef.value?.element ?? null fallback only fires when Atom exposes no element (renderless mode). No existing test rendered Cancel as renderless. - AlertDialogContent.vue:159-160 — onClose() was wired to the native 'close' event but nothing dispatched one; only the parallel onCancel path (native 'cancel' event) had coverage. Add one test for each.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The AlertDialog docs state that initial focus should land on the Cancel button — the least-destructive action — per the WAI-ARIA Authoring Practices alertdialog pattern. However,
AlertDialogContentnever called.focus()on the Cancel element; focus landed wherever the browser defaulted.Closes #609.
Solution
AlertDialogRoot.vue— AddedcancelEl: ShallowRef<HTMLElement | null>toAlertDialogContextso child components can share a reference to the Cancel button's DOM element.AlertDialogCancel.vue— Addedref="cancel"on theAtomelement, then usedonMounted/onUnmountedto register/deregister the underlying DOM element incontext.cancelEl.AlertDialogContent.vue— AddedfocusCancel()(context.cancelEl.value?.focus()) and called it immediately aftershowModal()in both thewatchhandler andonMounted.