Repository navigation
Add pre-commit with file formatting and GitHub action for running - #33
Open
williambdean wants to merge 9 commits into
Open
williambdean wants to merge 9 commits into
williambdean wants to merge 9 commits into
Conversation
Contributor
Author
|
Take a look @walkerke and let me know your thoughts. Large ammount of changes are automated or wouldve been caught at commit |
Owner
|
Thanks! I'll work through this - I'm updating some other stuff first, such as some of the underlying package infrastructure. If you have time, would you mind rebasing to grab the latest code? |
…changes Upstream changes to data/enumeration_units/helpers/legislative landed after the formatting pass, so ruff fixes (mutable defaults, isna, bare except removal, unused-variable noqa, next() over slice, line wrapping) are re-applied on top of them.
williambdean
force-pushed
the
add-pre-commit
branch
from
October 18, 2026 15:39
377a54a to
0b7b1e4
Compare
Contributor
Author
|
Hi @walkerke , finally getting back to this. Rebased and then worked through some of the recent yellings from ruff formating. Should be in a good place now |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
pre-committo handle linting and formatting automatically.Some common ruff rules are added. Read more here