Repository navigation
Fix network data logging - #2248
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused logging change is correct, consistently applied, and adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Adds lazy Base64 encoding for network payload logs, avoiding unnecessary encoding when debug logging is disabled.
Changes:
- Introduces
logging.Datafor lazy Base64 formatting. - Updates peer and networking logs to use structured attributes.
- Adds text/JSON tests and a discarded-log benchmark.
| File | Description |
|---|---|
pkg/p2p/peer/peer_impl.go |
Updates outgoing peer data logging. |
pkg/p2p/peer/handle.go |
Updates incoming peer data logging. |
pkg/networking/session.go |
Uses lazy payload encoding in session logs. |
pkg/logging/logging.go |
Adds the Data logging attribute helper. |
pkg/logging/logging_internal_test.go |
Tests and benchmarks the helper. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
alexeykiselev
added
the
run-itests
github-actions
Bot
removed
the
run-itests
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.