Skip to content

feat(backup): surface incrementalBaseBackupId on backup status and list - #477

Closed
OsamaAnsar wants to merge 1 commit into
weaviate:mainfrom
OsamaAnsar:feature/backup-incremental-base-id
Closed

OsamaAnsar wants to merge 1 commit into
weaviate:mainfrom
OsamaAnsar:feature/backup-incremental-base-id

Conversation

@OsamaAnsar

Copy link
Copy Markdown
Contributor

Summary

Closes #441.

Exposes incrementalBaseBackupId on BackupStatusReturn — the ID of the base backup a file-based incremental backup was built on (empty/absent when the backup is not incremental). Mirrors weaviate-python-client#2116.

The field is already in the vendored OpenAPI spec (incremental_base_backup_id on BackupCreateStatusResponse and BackupListResponse); it just wasn't mapped through to the public types.

Changes

  • src/openapi/types.ts — export BackupListResponse
  • src/collections/backup/types.ts — incrementalBaseBackupId?: string on BackupStatusReturn (inherited by BackupReturn)
  • src/collections/backup/client.ts — parseStatus maps it from the create-status response; backup.list() maps it from each list entry (other list-response quirks left untouched)
  • test/collections/backup/mock.test.ts — mock the list + create-status endpoints returning incremental_base_backup_id; 2 tests asserting it surfaces (and stays undefined for a non-incremental backup)

Testing

npx tsc --noEmit, eslint, prettier --check clean. test/collections/backup/mock.test.ts passes (8/8, including the 2 new).

@OsamaAnsar

Copy link
Copy Markdown
Contributor Author

I agree with the CLA

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@weaviate-git-bot

Copy link
Copy Markdown

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Forum?

@dudanogueira

Copy link
Copy Markdown
Contributor

Duplicate of: #459

@OsamaAnsar

Copy link
Copy Markdown
Contributor Author

Closing in favor of #459 which covers this more broadly — thanks for the heads up @dudanogueira.

@OsamaAnsar OsamaAnsar closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add incrementalBaseBackupId return value for ListBackups

3 participants