Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
|
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
Author
|
I agree to the Weaviate Contributor License Agreement. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2170.
Keep
ttl_offset=Noneunchanged inReconfigure.ObjectTTL.delete_by_date_property, so partial updates preserve the existing offset. Previously, changing onlyfilter_expired_objectsalso resetdefaultTtlto zero and changed expiry timing. An explicit zero still resets the offset; the creation default remains zero.Added tests for preserving positive/negative offsets, explicit zero and timedelta values, and the creation default. The two preservation cases fail before the fix. Afterward,
test/collection/test_config_update.pyandtest/collection/test_config.pypass all 233 tests. Ruff lint/format, Flake8, and whitespace checks passed. No live-server integration test was run.AI assistance was used to investigate, implement, and test this patch.