Skip to content

fix(ci): limit Playwright concurrency - #731

Open
rsarika wants to merge 2 commits into
webex:nextfrom
rsarika:codex/fix-playwright-ci-cancellation
Open

fix(ci): limit Playwright concurrency#731
rsarika wants to merge 2 commits into
webex:nextfrom
rsarika:codex/fix-playwright-ci-cancellation

Conversation

@rsarika

@rsarika rsarika commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

COMPLETES #< INSERT LINK TO ISSUE >

This pull request addresses

< DESCRIBE THE CONTEXT OF THE ISSUE >

by making the following changes

< DESCRIBE YOUR CHANGES >

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

  • The testing is done with the amplify link
    < ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

Checklist before merging

  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the testing document
  • I have tested the functionality with amplify link

Make sure to have followed the contributing guidelines before submitting.

@rsarika
rsarika requested a review from a team as a code owner August 6, 2026 08:31
@rsarika rsarika added validated Indicates that the PR is ready for actions run_e2e Add this label to run E2E test for meeting and CC widgets labels Aug 6, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 798cf81ab5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +144 to +147
const oauthTasks = buildOAuthTasksForSetGroup(userSetKeys);
// Apply one global concurrency limit. Running a separate batch loop per set
// group allowed up to 20 OAuth browser contexts to start at once in CI.
const tokenUpdates = await collectTokensInBatches(browser, oauthTasks);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the Playwright concurrency documentation

This replaces the five parallel OAuth set groups with one globally batched queue, while playwright/README.md:203-209 still describes the removed grouping behavior; the README also says workers always scale to USER_SETS.length at lines 216 and 261 despite the new four-worker CI cap. Update those standing instructions in this change so operators do not diagnose or size E2E runs using obsolete concurrency behavior.

AGENTS.md reference: AGENTS.md:L68-L68

Useful? React with 👍 / 👎.

@aws-amplify-us-east-2

Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-731.d1b38q61t1z947.amplifyapp.com

@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Aug 6, 2026
@rsarika rsarika added the validated Indicates that the PR is ready for actions label Aug 6, 2026
@rsarika
rsarika force-pushed the codex/fix-playwright-ci-cancellation branch from 32154b0 to f9af52d Compare August 6, 2026 11:54
@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Aug 6, 2026
@rsarika rsarika added the validated Indicates that the PR is ready for actions label Aug 6, 2026
@github-actions github-actions Bot removed the validated Indicates that the PR is ready for actions label Aug 6, 2026
@rsarika rsarika added the validated Indicates that the PR is ready for actions label Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run_e2e Add this label to run E2E test for meeting and CC widgets validated Indicates that the PR is ready for actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant