Repository navigation
Conversation
🤖 Webitel Code ReviewДодано пісочницю (sandbox) та безпечну обробку для SQLite в ExternalStoreManager. Оновлено конфігурацію зовнішніх SQL-сховищ (ExternalSQLSettings), додано перевірки шляхів та обмеження прав доступу (read-only за замовчуванням, заборона ATTACH DATABASE), оновлено залежність go-sqlite3 до v1.14.52 та додано розширене модульне тестування. 📋 Walkthrough (8 файл(и/ів))
Знахідки
🔸 Дрібниці / nitpicks (2)
🔗 Cross-repo callers змінених символів (11)
Index-grounded review across the Webitel codebase. Знахідки можуть бути неточними — перевіряйте перед застосуванням. |
suifri
force-pushed
the
security/WTEL-10639-sqllite-sandbox-root
branch
2 times, most recently
from
October 16, 2026 16:04
661d94a to
37a430a
Compare
suifri
force-pushed
the
security/WTEL-10639-sqllite-sandbox-root
branch
from
October 16, 2026 16:14
37a430a to
ad1d06d
Compare
| ext := &ExternalDb{db: db} | ||
|
|
||
| e.cache.AddWithDefaultExpires(key, ext) | ||
| e.logger.Info("store cache db", wlog.String("driver", cfg.Driver)) |
There was a problem hiding this comment.
Запобігання nil pointer dereference у разі відсутності ініціалізованого логера
Suggested change
| e.logger.Info("store cache db", wlog.String("driver", cfg.Driver)) | |
| if e.logger != nil { e.logger.Info("store cache db", wlog.String("driver", cfg.Driver)) } |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.