Repository navigation
support Unicode text and HEIC image upload - #1529
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the three recent Sentry errors on kvittering:
'latin-1' codec can't encode …(KVITTERING-71, -72): the PDF core fonts only support latin-1, so emojis, iOS smart quotes and names with characters outside latin-1 crashed the generation. Migrated from the unmaintainedfpdftofpdf2and embedded DejaVu Sans, with Noto Emoji as fallback for emoji glyphs.UnidentifiedImageError … .heic(KVITTERING-4C): iOS 18 HEIC files use thetmap(HDR gain map) brand, which libheif 1.16 cannot parse. Bumpedpillow-heifto 1.x (libheif 1.23).Also adds regression tests for both cases.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Testing
Resolves #1516, #1517