Tighten decoder image/alloc caps and fail closed on Huffman amplification - #19
Open
M0nd0R wants to merge 1 commit into
Open
Tighten decoder image/alloc caps and fail closed on Huffman amplification#19M0nd0R wants to merge 1 commit into
M0nd0R wants to merge 1 commit into
Conversation
…lification. Align MAX_IMAGE_AREA with the encoder WEBP_MAX_DIMENSION limit, lower the default WEBP_MAX_ALLOCABLE_MEMORY ceiling from 16GiB to 1GiB, and reject lossless meta-Huffman bitstreams that advertise more than 1000 groups instead of still parsing unused tables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_IMAGE_AREAwith the encoderWEBP_MAX_DIMENSION(16383²) so crafted VP8X dimensions cannot request multi-GiB canvases.WEBP_MAX_ALLOCABLE_MEMORYfrom 16GiB to 1GiB (overrideable at compile time).Test plan