feat: support universal platform as a web target#5690
Conversation
|
| Name | Type |
|---|---|
| webpack-dev-server | Minor |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
There was a problem hiding this comment.
I'm not sure a unit test is worth it, but I'll add one. If you'd rather remove it, that's fine with me. Or if you'd prefer an E2E test, just let me know.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5690 +/- ##
==========================================
- Coverage 88.93% 88.92% -0.01%
==========================================
Files 13 13
Lines 5919 5932 +13
==========================================
+ Hits 5264 5275 +11
- Misses 655 657 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary
We already supported this on
main—the[node, web]combination—but it was removed when theisWebTargetmethod was simplified. So I'm adding it back now, along with support for theuniversalplatform. If we were to raise the peer dependency version, we could simplify the function even further, but I don't think it's worth doing that yet.What kind of change does this PR introduce?
Did you add tests for your changes?
Does this PR introduce a breaking change?
If relevant, what needs to be documented once your changes are merged or what have you already documented?
Use of AI