Skip to content

feat: support universal platform as a web target#5690

Open
bjohansebas wants to merge 3 commits into
nextfrom
universal-target
Open

feat: support universal platform as a web target#5690
bjohansebas wants to merge 3 commits into
nextfrom
universal-target

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

Summary

We already supported this on main—the [node, web] combination—but it was removed when the isWebTarget method was simplified. So I'm adding it back now, along with support for the universal platform. If we were to raise the peer dependency version, we could simplify the function even further, but I don't think it's worth doing that yet.

What kind of change does this PR introduce?

Did you add tests for your changes?

Does this PR introduce a breaking change?

If relevant, what needs to be documented once your changes are merged or what have you already documented?

Use of AI

@changeset-bot

changeset-bot Bot commented Jun 25, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ebb60fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 1 package
Name Type
webpack-dev-server Minor

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure a unit test is worth it, but I'll add one. If you'd rather remove it, that's fine with me. Or if you'd prefer an E2E test, just let me know.

@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.92%. Comparing base (4810909) to head (ebb60fc).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #5690      +/-   ##
==========================================
- Coverage   88.93%   88.92%   -0.01%     
==========================================
  Files          13       13              
  Lines        5919     5932      +13     
==========================================
+ Hits         5264     5275      +11     
- Misses        655      657       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant