Repository navigation
feat: write to Postgres, and drop the migrations that never ran - #13
Merged
Merged
Conversation
This service consumes CDC events and writes into the shared database, which is now Postgres. Only the sink driver and DSN change; the writes already go through GORM, which is dialect-neutral, so no query needed rewriting. The migrations are removed rather than converted. They created tables anime-api creates in the same database, tracked in the same schema_migrations table, so two services owned one schema -- the arrangement that already caused a collision between anime-api and news-ingest. They were also dead: event-chart has no migration job template, and every workload here runs a serve-* command, so `migrate up` has never run from this repository in production. The migrate cobra commands go with them. DBPORT now defaults to 5432 and DBSSL to require, matching the services already moved.
Contributor
Author
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This service consumes CDC events and writes into the shared database, which is now Postgres. Only the sink driver and DSN change — the writes already go through GORM, which is dialect-neutral, so no query in this repository needed rewriting.
The migrations are removed, not converted
They created tables anime-api creates, in the same database, tracked in the same
schema_migrationstable, with noDBMIGRATIONTABLEto separate them. Two services owning one schema is precisely the arrangement that already produced a collision between anime-api and news-ingest.They were also dead:
event-charthas no migration job template — only deployment, configmap, hpa, serviceserve-*command; none runsmigrateSo
migrate uphas never run from this repository in production. Themigratecobra commands go with them, since nothing is left for them to do.Config
DBPORTdefaults to5432,DBSSLtorequire, matching the five services already moved.🤖 Generated with Claude Code