Repository navigation
feat: store source work covers under /works/ - #17
Merged
Merged
Conversation
Work covers are about to be published to this service, and it had nowhere to put them: For() refuses a type it does not know, so every one would have been dropped silently. /works/<id> rather than the root. The root is keyed by anime id, and a work id there would be indistinguishable from one -- an upload that succeeds into a path something else already owns is exactly the failure this package exists to prevent, and it reports success either way. The test gains the case and a guard that a work never resolves to the anime root, matching the existing guard between anime and poster. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
🎉 This PR is included in version 1.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work covers are about to be published to this service (anime-sync companion PR) and it had nowhere to put them —
For()refuses an unknown type, so every one would have been dropped silently.The path
/works/<id>, not the root. The root is keyed by anime id, and a work id there would be indistinguishable from one. An upload that succeeds into a path something else already owns is precisely the failure this package exists to prevent — and it reports success either way, which is how a prefix bug once hid for a week.Tests
Added the case, plus a guard that a work never resolves to the anime root, mirroring the existing anime/poster guard:
go build ./...clean.