RFC 089: link to the spec in catalogue-api instead of carrying a copy - #168
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kenoir
marked this pull request as ready for review
August 28, 2026 15:06
kenoir
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview
What does this change?
The last item on the scope of work for wellcomecollection/platform#6530: RFC 089 stops carrying its own copy of the spec and links to the canonical one instead.
The spec moved into catalogue-api with the implementation, so the API Gateway body can template it from the same repository and there is no second copy to keep in step. The two copies were byte-identical when the move happened, so nothing is lost here.
Removed from
rfcs/089-identifiers-api/:openapi.yamlandopenapi.md, plus the smalluvproject that rendered them (render_docs.py,pyproject.toml,uv.lock,.python-version,.gitignore). That validate-and-render step now runs on every pull request in catalogue-api instead of by hand here. RFC 088 keeps its own copy of the same tooling and is untouched.No decisions change.
README.mdis all that remains in the directory, and the five cross-references to this RFC fromrfcs/README.md, RFC 085 and RFC 091 all point at that file, so none of them break.How to test
Read the amended "OpenAPI specification" section in the preview above, and follow the two links.
validate_rfc.pyandcreate_table_summary.py --check-readmeboth pass locally.