feat(navbar): label icon controls on hover - #462
Open
mohamad-fallah wants to merge 1 commit into
Open
mohamad-fallah wants to merge 1 commit into
mohamad-fallah wants to merge 1 commit into
Conversation
Icon-only navbar controls had no visible labels, making their actions unclear. Use the shared tooltip for navigation and controls, and call the home page خانه. Keep the website link without a tooltip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The bottom navbar uses icon-only controls, so their actions are unclear until clicked.
Root cause
Navbar controls such as notifications and layout management had no hover labels.
Changes
Left out
No other navbar behavior or styling was changed.
Testing
bun testpassed: 272 tests across 40 files.