Skip to content

Ship tested Windows MSI and WinGet flow - #42

Merged
Vixman merged 8 commits into
mainfrom
feat/windows-winget-v0.1.7
Sep 1, 2026
Merged

Vixman merged 8 commits into
mainfrom
feat/windows-winget-v0.1.7

Conversation

@Vixman

@Vixman Vixman commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • fix Windows terminal, SSH and SSO compatibility
  • embed the executable payload in the MSI
  • test Windows MSI installation and uninstall in CI
  • verify Authenticode signatures during release
  • prepare first WinGet submission and release runbook

Test plan

  • Windows unit tests pass
  • Windows MSI smoke passes
  • Existing Python tests pass
  • Signing configuration reviewed by Ops

Note

Medium Risk
Touches Windows installer layout, release signing gates, and SSO completion behavior (narrower auto-complete path), plus new required CI checks that can block merges if Windows jobs fail.

Overview
Windows packaging and distribution get a full release path: the WiX MSI is x64, embeds the cabinet payload, uses Wildfoundry Ltd as publisher, and CI builds, silently installs, exercises the binary, checks machine PATH, and uninstalls instead of only parsing the .wxs. Branch rules and docs now require Windows unit tests and Windows MSI smoke; release adds post-sign Authenticode checks on the .exe and .msi.

WinGet: README steers users to winget install; prepare_manifest.py and an expanded bootstrap workflow build manifests from a published release tag (URL, SHA-256, date); update-winget pins winget-releaser to a fixed commit. New docs/windows-release.md documents signing, smoke, and first-submission constraints (e.g. skip broken v0.1.6 MSI).

CLI on Windows: remote_access uses optional POSIX terminals and msvcrt for console input; SSH tunneling uses os.devnull for host-key skipping. SSO auto-complete now only applies tokens from the local callback listener—removed code-exchange and GET /api/auth/sso/complete/ polling—so manual paste must already contain tokens.

Reviewed by Cursor Bugbot for commit 41b51a1. Configure here.

Comment thread .github/workflows/ci.yml Fixed
@Vixman
Vixman requested a review from a team as a code owner August 31, 2026 10:56

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Left a non-blocking comment: Cursor Bugbot stayed pending past the 8-minute wait, so this PR is not approved. Human review is needed; a reviewer was assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor
cursor Bot requested a review from barfle August 31, 2026 11:04

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 41b51a1. Configure here.

Comment thread dataplicity_cli/cli.py Outdated
Comment thread dataplicity_cli/cli.py
Comment thread dataplicity_cli/remote_access.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a non-blocking comment: Cursor Bugbot reported unresolved findings that need human review, so this PR is not approved. A reviewer is already assigned. Cursor Security Agent was not running after the first check poll.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

cursor[bot]
cursor Bot previously approved these changes Sep 1, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Present automated-review checks were clean after skipping Cursor Security Agent (not running after the first poll), and prior Cursor Bugbot findings are resolved. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot and Cursor Security Agent were not running after the first check poll, and prior Bugbot findings are resolved. No reviewers were assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Router and Approver

@Vixman
Vixman merged commit 235b97a into main Sep 1, 2026
12 checks passed
@Vixman
Vixman deleted the feat/windows-winget-v0.1.7 branch September 1, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants