Ship tested Windows MSI and WinGet flow - #42
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 3 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 41b51a1. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Test plan
Note
Medium Risk
Touches Windows installer layout, release signing gates, and SSO completion behavior (narrower auto-complete path), plus new required CI checks that can block merges if Windows jobs fail.
Overview
Windows packaging and distribution get a full release path: the WiX MSI is x64, embeds the cabinet payload, uses Wildfoundry Ltd as publisher, and CI builds, silently installs, exercises the binary, checks machine PATH, and uninstalls instead of only parsing the
.wxs. Branch rules and docs now require Windows unit tests and Windows MSI smoke; release adds post-sign Authenticode checks on the.exeand.msi.WinGet: README steers users to
winget install;prepare_manifest.pyand an expanded bootstrap workflow build manifests from a published release tag (URL, SHA-256, date);update-wingetpins winget-releaser to a fixed commit. Newdocs/windows-release.mddocuments signing, smoke, and first-submission constraints (e.g. skip broken v0.1.6 MSI).CLI on Windows:
remote_accessuses optional POSIX terminals andmsvcrtfor console input; SSH tunneling usesos.devnullfor host-key skipping. SSO auto-complete now only applies tokens from the local callback listener—removed code-exchange andGET /api/auth/sso/complete/polling—so manual paste must already contain tokens.Reviewed by Cursor Bugbot for commit 41b51a1. Configure here.