Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MySQL
REPLACEis a statement, not anINSERTmodifier.csvsql --prefix REPLACE --insertcurrently emitsINSERT REPLACE INTO ...and fails with MySQL error 1064.Use a separate SQLAlchemy
Insertsubclass for MySQL replacement writes. Its dialect compiler retains SQLAlchemy's column quoting and bound parameters while changing the leading keyword toREPLACE. Other modifiers, ordinary inserts, chunking, and SQLite'sOR REPLACEkeep their existing paths; the caller's prefix list is not modified.Fixes #44.
Validation:
LOW_PRIORITY, unchangedINSERT IGNORE, bound values containingINSERT REPLACE, and caller-controlled rollback pass.Local validation used Linux/Python 3.12. The full OS/Python CI matrix was not run. This change leaves transaction ownership unchanged: csvsql starts and commits its own transaction; the separate owned-connection issue in #68 is independent.
AI-assisted implementation and validation.