fix: binary-split gguf URL name extraction - #662
Merged
Merged
Conversation
A path like models/old.gguf/new.gguf.part1of2 was expanded from the first .gguf, so the download URLs dropped new.gguf.
giladgd
changed the title
giladgd
changed the title
|
🎉 This PR is included in version 3.22.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
Author
|
Thanks for merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveBinarySplitGgufPartUrls("https://example.com/models/old.gguf/new.gguf.part1of2")returned URLs forold.gguf.part1of2andold.gguf.part2of2. The cut used the first.ggufin the path.new.gguf, and the filename isnew.gguf. A path with one.ggufis unchanged.Test plan
vitestontest/standalone/utils/modelDownloader.test.ts, 4 passed.