Add timeout to TPM SSH workflow to prevent multi-hour hangs#1046
Open
aidangarske wants to merge 1 commit into
Open
Add timeout to TPM SSH workflow to prevent multi-hour hangs#1046aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TPM SSH Test workflow has no job timeout, so it inherits GitHub's 6-hour default. This run hung for ~2 hours before being cancelled.
Changes:
timeout-minutes: 20at the job level so any hung matrix leg is killed instead of running for hours. The job normally finishes in a few minutes.timeout 20. Unlike the host-key test (already wrapped intimeout 20), the bareclientinvocation had no timeout and is the most likely indefinite-hang source — this makes it fail fast and cleanly rather than consuming the full job budget.