Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reject signed OAuth state tokens whose timestamp is non-finite or ahead of the current time. Add a regression test for a state created one second in the future.
Why
The existing check rejected only
age > ttlMs; negative ages and NaN were accepted. A future-dated, otherwise valid state could remain valid beyond its intended five-minute lifetime. This keeps the OAuth state TTL boundary explicit without changing the normal state flow.Validation
bunx vitest run packages/server/src/services/oauth/state-manager.test.ts(3 passed)bunx turbo typecheck --filter=@onequery/server --json(passed)bunx oxfmt --check packages/server/src/services/oauth/state-manager.ts packages/server/src/services/oauth/state-manager.test.ts(passed)git diff --check(passed)Note: local
oxlintpanicked in its Rust allocator, so lint needs CI verification.