Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Require every provider HTTP endpoint to resolve to the configured API origin before adding credentials or calling fetch. Reject absolute and protocol-relative cross-origin endpoints while preserving same-origin absolute URL support. Add regression tests that assert no fetch occurs for rejected endpoints.
Why
ProviderHttpClientattaches a stored bearer, basic or raw token to every request, yet previously accepted any absolutehttps://endpoint or//-relative path. A misconfigured endpoint or untrusted URL could send the provider credential to a different origin. This guard applies to the shared HTTP client rather than relying on each caller to make the same safety check.Validation
bunx vitest run packages/server/src/services/provider-http-client.test.ts packages/server/src/source-api/adapters/github.test.ts(12 passed)bunx turbo typecheck --filter=@onequery/server --json(passed)bunx oxfmt packages/server/src/services/provider-http-client.ts packages/server/src/services/provider-http-client.test.tsandgit diff --check(passed)Local oxlint panicked in its Rust allocator; CI should verify lint.