Repository navigation
Fix PHPStan errors - #253
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe shutdown callback no longer captures a preallocated error array. It still obtains the last error with ChangesShutdown callback
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The change removes an unused allocation while preserving the shutdown callback’s revert and memory-limit diagnostic behavior. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Fixes the newly reported PHPStan error from the scheduled code quality run (https://github.com/wp-cli/package-command/actions/runs/37563545559):
The shutdown closure imported a dummy
$error_array"to preallocate memory", but it immediately overwrote it witherror_get_last(). Because the new value is created before the old one is freed, the preallocation never saved any memory. This PR removes the dummy array and drops it from theuselist.🤖 Generated with Claude Code
https://claude.ai/code/session_014Q2gK8eSLNEQDwqibeyVJ6
Generated by Claude Code
Summary by CodeRabbit