Repository navigation
Bump hazelcast orbit bundle to 5.3.7.wso2v3 - #4640
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: wso2/carbon-kernel/.coderabbit.yml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe parent POM updates the managed Hazelcast Orbit version from ChangesHazelcast Orbit version update
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The PR advances the managed Hazelcast Orbit bundle version. No concrete compatibility or packaging issue is identified in the reviewed context, so no merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 OSV Scanner (2.6.0)parent/pom.xmlOSV Scanner exited with code 128 without a usable report Comment |
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
Review effort: Lite
Findings: None
What changed in this PR
Updates the build to consume the newer WSO2 Orbit bundle for Hazelcast 5.3.7, picking up the re-shaded Jackson 2.22.3 embedded in the bundle.
Changes:
- Bump
orbit.version.hazelcastfrom5.3.7.wso2v2to5.3.7.wso2v3in the parent POM.
| File | Description |
|---|---|
| parent/pom.xml | Updates Hazelcast Orbit bundle version to wso2v3 to pick up updated shaded Jackson packaging. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Purpose
Pick up
hazelcast 5.3.7.wso2v3(orbit#1422), which re-shades Jackson to 2.22.3 in place of the copy upstream Hazelcast embeds incom.hazelcast.shaded.com.fasterxml.jackson. That copy is not reachable from any pom property, so moving it means a new orbit bundle rather than a version bump here.Approach
parent/pom.xml:orbit.version.hazelcast5.3.7.wso2v2→5.3.7.wso2v3.Hazelcast itself stays at 5.3.7, and the bundle's embedded dependency set is otherwise unchanged — everit-json-schema 1.14.3, HikariCP 4.0.3, classgraph 4.8.158, org.json 20231013, snakeyaml-engine 2.6. Jackson is the only thing that moves.
5.3.7.wso2v3's OSGi manifest is identical to5.3.7.wso2v2's when both are built with the same toolchain: 622Import-Packageand 571Export-Packageentries, same sets, no mandatory imports.Testing
mvn clean installonparent,core/org.wso2.carbon.hazelcastandfeatures/org.wso2.carbon.hazelcast.featureis green, and the feature zip shipsplugins/hazelcast-5.3.7.wso2v3.jarwith nowso2v2reference left.