Improve XDebug instructions - #376
misterjoonas wants to merge 2 commits into
Conversation
|
Let's try to find out the real cause for this ;) |
tormi
left a comment
tormi
left a comment
There was a problem hiding this comment.
This sounds like something we shouldn't document because it can happen to any service and we should avoid overloading the documentation. What do you think?
|
I just suggested instructions for an easy way to validate that XDebug is actually running. For someone who has never worked with XDebug before, it can feel like nothing happens when XDebug is enabled, you just need to trust it has loaded and then hope that it works with the editor of your choice. |
|
Also @ragnarkurmwunder was working on this. He has some docs on his computer. Ping him. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Update the Lando documentation to match the repository’s DDEV setup.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Improves README guidance for local development and Xdebug.
Changes:
- Adds development command documentation.
- Adds Xdebug verification and troubleshooting guidance.
| File | Summary | Review comment |
|---|---|---|
README.md |
Adds command and Xdebug documentation. | Remove or replace the Lando command block (lines 259 and 264), as this repository uses DDEV. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - `lando` - tools / commands overview. | ||
| - `lando grumphp <commands>` - run [GrumPHP](https://github.com/phpro/grumphp) code quality checks. Modified or new files are checked on git commit, see more at `lando grumphp -h` or [wunderio/code-quality](https://github.com/wunderio/code-quality). | ||
| - `lando npm <commands>` - run [npm](https://www.npmjs.com/) commands. | ||
| - `lando phpunit <commands>` - run [PHPUnit](https://phpunit.de/) commands. | ||
| - `lando varnishadm <commands>` - run [varnishadm](https://varnish-cache.org/docs/6.0/reference/varnishadm.html) commands. |
No description provided.