Conversation
Author
|
In addition to the arch packaging, I had Astra add a workaround for Tao's inner window sizing discrepancy under Wayland. Tao reports dimensions that include window decorations, and Tauri uses those dimensions for sage's main webview. Ideally this gets fixed upstream, but this should help in the meantime. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Arch Linux x86_64 packages to the existing build and release workflow.
pnpm package:archbuilds the current checkout with makepkg, packages the wallet and its built-in apps, and produces a pacman package alongside the other Tauri bundles. The launcher includes the documented NVIDIA explicit-sync workaround, and the packaging guide covers building, installing, and updating the package.Native Wayland can place Logout and other bottom controls below the visible window because Tauri's resize event includes the GTK title bar. Size the main webview from GTK's content allocation only when GTK reports an active Wayland backend. X11 and XWayland keep Tauri's existing resize behavior, including when
WAYLAND_DISPLAYis also set. The Arch package release is incremented to 4.Validation on Arch Linux with Rust 1.98.1:
pnpm exec tauri build --no-bundle -- --frozen(including frontend and built-in apps).cargo clippy -p sage-tauri --all-features --all-targets --frozenandcargo fmt --all -- --check.node --test scripts/package-arch.test.mjs, launcher/PKGBUILD syntax checks, and formatting of the updated guide.GDK_BACKEND=x11andWAYLAND_DISPLAYstill set, viewport and Logout bounds match the unpatched binary.Implementation assisted by Astra.