Conversation
Hadamcik
reviewed
Sep 9, 2026
| 'share/icons/hicolor/256x256@2/apps/com.rigidnetwork.sage.png', | ||
| 'share/licenses/com.rigidnetwork.sage/LICENSE', | ||
| 'lib/Sage/builtin-apps/system/app-install/sage-manifest.json', | ||
| 'lib/Sage/builtin-apps/runtime/origin-cleanup/sage-manifest.json', |
Author
There was a problem hiding this comment.
Sorry about that! That was courtesy of Astra's laziness, and my negligence. For whatever reason, it is having a terrible time following sage's conventions. Anyway, I have removed that.
Author
There was a problem hiding this comment.
I'm still giving it a once-over, stand by.
Author
There was a problem hiding this comment.
...like pulling teeth. I believe I've found and removed all the superfluous instances. Other than that, there's a LICENSE install invocation in https://github.com/xch-dev/sage/pull/865/changes#diff-519ff41b69e71faf2fe3c808ede06b7e92d89b561fb5e154434121209bdce88eR27 , that is a Flatpak packaging convention that I would suggest leaving alone.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self explanatory.