formula: qhull/qhull - #507
MeteorsLiu wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Reviewed the qhull formula across the complete fixed diff, including the version comparator, patch selection, CMake install behavior, option combinations, pkg-config metadata, and consumer test. The implementation is generally coherent, but the shared Windows consumer path has a concrete runtime failure described inline. git diff --check reports whitespace in imported patch payloads, and versions.json parses successfully; the llar executable is not available in this workspace, so the repository's end-to-end formula command could not be run.
| os.setenv("LD_LIBRARY_PATH", filepath.join(installDir, "lib"))! | ||
| os.setenv("DYLD_LIBRARY_PATH", filepath.join(installDir, "lib"))! |
There was a problem hiding this comment.
[P1] Add the installed bin directory to PATH for Windows shared tests
When shared is ON on Windows, CMake installs the DLL under the formula's bin directory (RUNTIME DESTINATION), but this test only sets LD_LIBRARY_PATH and DYLD_LIBRARY_PATH. The compile can succeed while exec! binary then fails to load qhull_r.dll/qhull.dll, so every shared Windows configuration is rejected even though the package was built correctly. Set PATH to include filepath.join(installDir, "bin") for Windows, preserving the existing PATH.
Summary:
Validation:
Closes #251