Skip to content
This repository was archived by the owner on Sep 20, 2026. It is now read-only.

formula: qhull/qhull - #507

Open
MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/251-qhull-luna
Open

MeteorsLiu wants to merge 2 commits into
xgo-dev:mainfrom
MeteorsLiu:issue/251-qhull-luna

Conversation

@MeteorsLiu

Copy link
Copy Markdown
Collaborator

Summary:

  • Add an idiomatic qhull/qhull LLAR Formula from the pinned Conan Center recipe.
  • Cover v7.3.2 through the recipe’s v8.0.x patch paths, options, relocatable pkg-config metadata, and consumer verification.

Validation:

  • Exact LLAR 9c062aa5c4b1724bfd30cb72f7e0bda136f9c078 on darwin/arm64.
  • v7.3.2, v8.0.0, v8.0.1, option matrix, cache-hit, installed metadata, and below-floor rejection checks.

Closes #251

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the qhull formula across the complete fixed diff, including the version comparator, patch selection, CMake install behavior, option combinations, pkg-config metadata, and consumer test. The implementation is generally coherent, but the shared Windows consumer path has a concrete runtime failure described inline. git diff --check reports whitespace in imported patch payloads, and versions.json parses successfully; the llar executable is not available in this workspace, so the repository's end-to-end formula command could not be run.

Comment on lines +198 to +199
os.setenv("LD_LIBRARY_PATH", filepath.join(installDir, "lib"))!
os.setenv("DYLD_LIBRARY_PATH", filepath.join(installDir, "lib"))!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Add the installed bin directory to PATH for Windows shared tests

When shared is ON on Windows, CMake installs the DLL under the formula's bin directory (RUNTIME DESTINATION), but this test only sets LD_LIBRARY_PATH and DYLD_LIBRARY_PATH. The compile can succeed while exec! binary then fails to load qhull_r.dll/qhull.dll, so every shared Windows configuration is rejected even though the package was built correctly. Set PATH to include filepath.join(installDir, "bin") for Windows, preserving the existing PATH.

This branch has not been deployed

No deployments
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translate Conan Center qhull recipe to LLAR

1 participant