Repository navigation
fix(sandbox): pick sandboxd binary by TARGETARCH instead of forcing a… - #673
Merged
Merged
Conversation
…md64 The sandbox image Dockerfile declared `ARG TARGETARCH=amd64` globally, which pinned the busybox picker stage to the x86_64 sandboxd binary even when building for linux/arm64. As a result the published ghcr.io/xiaods/k8e-sandbox arm64 image shipped an x86_64 /sandboxd, causing 'exec format error' when the gVisor runtime tried to start the sandbox process on the ARM64 VM. Remove the forced default so BuildKit populates TARGETARCH from the target platform; the release workflow already builds with `platforms: linux/amd64,linux/arm64` via docker/build-push-action. Add a verification step to the build-sandbox-image job that inspects the built sandbox image platforms with docker buildx imagetools inspect.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…md64
The sandbox image Dockerfile declared
ARG TARGETARCH=amd64globally, which pinned the busybox picker stage to the x86_64 sandboxd binary even when building for linux/arm64. As a result the published ghcr.io/xiaods/k8e-sandbox arm64 image shipped an x86_64 /sandboxd, causing 'exec format error' when the gVisor runtime tried to start the sandbox process on the ARM64 VM.Remove the forced default so BuildKit populates TARGETARCH from the target platform; the release workflow already builds with
platforms: linux/amd64,linux/arm64via docker/build-push-action.Add a verification step to the build-sandbox-image job that inspects the built sandbox image platforms with docker buildx imagetools inspect.