Conversation
## Why Solid block glyphs use fractional eighth-cell rectangles. At odd device-cell sizes, Canvas2D antialiasing leaves partial alpha in the WebGL atlas and exposes seams between touching blocks. ## What changed - Snap absolute octant boundaries to integer device pixels when an axis has at least eight pixels. - Preserve fractional coordinates below eight pixels so one-eighth stripes stay visible. - Keep other custom glyph types and renderers unchanged. - Add geometry and atlas regression coverage. ## Testing - Covers odd 9-pixel cells, the 7-pixel fallback, composite quadrants, complementary halves, sparse stripes, and checkerboards.
## Why The fixed eight-pixel threshold leaves composite block glyphs antialiased at seven-pixel cell widths even when their geometry can be snapped without loss. ## What changed - Validate the rounded absolute boundaries used by each glyph axis. - Snap safe seven-pixel quadrant and checkerboard geometry. - Preserve fractional fallback when a used boundary would collapse. ## Testing Covers seven- and nine-pixel shared boundaries, intentional gaps, fractional offsets, narrow stripes, and WebGL atlas opacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Solid octant block glyphs are drawn from rectangles positioned on an
eighth-cell grid. When a device-cell dimension is not divisible by eight,
fractional rectangle edges are antialiased in the WebGL texture atlas. This can
leave softened edges or visible seams in composite quadrant glyphs, including
at common seven-pixel cell widths.
For example:
Snapping every rectangle outward closes seams but can expand intentional gaps.
Always snapping shared boundaries can instead collapse narrow one-eighth
features when a cell dimension contains fewer than eight pixels.
What changed
remains distinct after rounding.
intentional gap.
Testing
cell widths.
checkerboard topology.
pixels while an unsafe seven-pixel one-eighth stripe remains visible with
fractional coverage.
lint.