Repository navigation
i18n: fail tests when a complete area misses a key, and fill the 7 gaps - #413
Conversation
|
@Circout-sudo is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi @Circout-sudo, welcome to DesignHub and thanks for your first pull request! 🎉 DesignHub is an open-source, local-first design and brand toolkit that runs entirely in the browser: set up a brand once and get logo variants, mockups, social media assets, a brand guidelines PDF and design tokens, plus typography, color, icon, background, effects, SVG and accessibility tools. No login, no backend, no API keys. A maintainer will review this soon. Meanwhile, please check that If you like the project, a ⭐ on the repository helps other people find it. Feel free to contribute more! Issues labeled |
|
@Circout-sudo fix CI Fails |
Closes #407
What changed
A missing translation falls back to English, so nothing noticed when an area was complete and then lost a key. Spanish, French and Hindi each lacked 7 keys that the English catalog has, and the tests did not catch it.
completeAreas, of the key prefixes that are complete in all four languages.completeAreas. It fails with the missing keys listed per language.docs/translating.mdto point atcompleteAreas.Details
svg.compare.toggle,svg.compare.original,svg.compare.optimized,svg.compare.divider,svg.compare.value,svg.compare.instructionsandnav.github.{original},{optimized}) are unchanged, and there are no em dashes.completeAreascontains a prefix with no English keys, which catches typos in the list.How to check
fr.ts, for examplenav.security, and runpnpm test. The test fails and namesfrand that key.pnpm typecheck,pnpm test,pnpm lint,pnpm format:check,pnpm check:dashesandpnpm buildpass.Note for reviewers
Native review of the Hindi strings would be welcome, especially "विभाजक" for "divider" and "ऑप्टिमाइज़" for "optimize".