Skip to content

i18n: fail tests when a complete area misses a key, and fill the 7 gaps - #413

Merged
yakew7 merged 10 commits into
yakew7:mainfrom
Circout-sudo:main
Oct 23, 2026
Merged

yakew7 merged 10 commits into
yakew7:mainfrom
Circout-sudo:main

Conversation

@Circout-sudo

Copy link
Copy Markdown
Contributor

Closes #407

What changed

A missing translation falls back to English, so nothing noticed when an area was complete and then lost a key. Spanish, French and Hindi each lacked 7 keys that the English catalog has, and the tests did not catch it.

  • Translated the 7 missing keys in es, fr and hi.
  • Added one exported list, completeAreas, of the key prefixes that are complete in all four languages.
  • Replaced the two hard-coded area lists in the tests with a single test that uses completeAreas. It fails with the missing keys listed per language.
  • Updated docs/translating.md to point at completeAreas.

Details

  • The 7 keys are svg.compare.toggle, svg.compare.original, svg.compare.optimized, svg.compare.divider, svg.compare.value, svg.compare.instructions and nav.github.
  • I checked every key prefix against es, fr and hi before adding it. After the 7 keys were filled, all 22 top-level areas were complete, so all of them are in the list.
  • Placeholders ({original}, {optimized}) are unchanged, and there are no em dashes.
  • I added a small test that fails if completeAreas contains a prefix with no English keys, which catches typos in the list.

How to check

  • Delete a key from fr.ts, for example nav.security, and run pnpm test. The test fails and names fr and that key.
  • pnpm typecheck, pnpm test, pnpm lint, pnpm format:check, pnpm check:dashes and pnpm build pass.

Note for reviewers

Native review of the Hindi strings would be welcome, especially "विभाजक" for "divider" and "ऑप्टिमाइज़" for "optimize".

@Circout-sudo
Circout-sudo requested a review from yakew7 as a code owner October 23, 2026 10:40
@vercel

vercel Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

@Circout-sudo is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

Hi @Circout-sudo, welcome to DesignHub and thanks for your first pull request! 🎉

DesignHub is an open-source, local-first design and brand toolkit that runs entirely in the browser: set up a brand once and get logo variants, mockups, social media assets, a brand guidelines PDF and design tokens, plus typography, color, icon, background, effects, SVG and accessibility tools. No login, no backend, no API keys.

A maintainer will review this soon. Meanwhile, please check that pnpm typecheck && pnpm lint && pnpm format:check && pnpm build pass and that the PR template checklist is filled in.

If you like the project, a ⭐ on the repository helps other people find it.

Feel free to contribute more! Issues labeled good first issue and help wanted come with step-by-step instructions, and CONTRIBUTING.md has the setup and style guide. Questions are always welcome in the comments.

@yakew7

yakew7 commented Oct 23, 2026

Copy link
Copy Markdown
Owner

@Circout-sudo fix CI Fails

@yakew7
yakew7 merged commit f044c85 into yakew7:main Oct 23, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n: fail the tests when a translated area misses a key, and fill the 7 gaps

2 participants