Skip to content

fix: prevent subset benchmarks from overwriting other results - #1165

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:fix/issue-1151-benchmark-output-guard
Oct 25, 2026
Merged

yakew7 merged 1 commit into
yakew7:mainfrom
dxnnystyles:fix/issue-1151-benchmark-output-guard

Conversation

@dxnnystyles

Copy link
Copy Markdown
Contributor

Summary

checks existing benchmark output before writing. subset runs that would remove other audits, or replace incomplete or inconsistent output, now stop with a clear error. compatible reruns remain supported.

Type

  • Audit
  • Explainer
  • Bug fix
  • Other

How I Tested

Linked issue

Closes #1151

@vercel

vercel Bot commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

@dxnnystyles is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

Copy link
Copy Markdown

@yakew7 @ahmdkaml - new PR touching a path you own, please review.

@yakew7
yakew7 merged commit c5f95c8 into yakew7:main Oct 25, 2026
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

faircode benchmark overwrites the results for every audit when run on a subset into an existing directory

2 participants