Repository navigation
fix: prevent subset benchmarks from overwriting other results - #1165
Merged
yakew7 merged 1 commit intoOct 25, 2026
Merged
Conversation
Contributor
|
@dxnnystyles is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checks existing benchmark output before writing. subset runs that would remove other audits, or replace incomplete or inconsistent output, now stop with a clear error. compatible reruns remain supported.
Type
How I Tested
python -m pytest tests/test_results_provenance.py -q(15 passed).python -m pytest tests/ -q -m "not slow"(1,244 passed, 1 skipped, 23 deselected).ruff check faircode/benchmark.py faircode/cli.py tests/test_results_provenance.py tests/test_benchmark.pyandgit diff --checkpassed.make lintstops at existing closed issue references inROADMAP.md(JSON string cells "NA" and "" are missing in the web engine and ordinary values in Python #1036, XLSX date cells are labelled 2020-01-01 00:00:00 by Python and by their serial number (43831) by the web engine #1039, Numeric column headers keep their type in Python (the integer 2020) and are text in the web engine #1045, An empty header cell is named Unnamed: 1 by pandas and an empty string by the web engine #1046, Two long group labels that share their first 29 characters still print identically after the ellipsis fix #1038).ruff format --checkreports these files would be reformatted; the upstream versions also fail that check.Linked issue
Closes #1151