Repository navigation
Add a skip link to every explainer page - #1184
Merged
Merged
Conversation
Signed-off-by: minutechreview <141821420+minutechreview@users.noreply.github.com>
minutechreview
requested review from
Shreyash0712,
ahmdkaml,
propcgamer20-png and
yakew7
as code owners
October 25, 2026 14:16
Contributor
|
@minutechreview is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 @Shreyash0712 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Every generated explainer page now starts with a "Skip to content" link, so keyboard users can jump past the top bar (WCAG 2.4.1).
Type
Details
scripts/build_explainers.py: the page template puts<a class="skip-link" href="#explainer-start">Skip to content</a>first in<body>. The target is the hero section (id="explainer-start" tabindex="-1"), not<main>: on these pages<main>also wraps the top bar, so a link to it would land back before the links it is meant to skip.explainer-startrather thancontentbecause heading ids are generated from heading text and a heading named "Content" would collide.assets/explainers.css: the same visually hidden.skip-link/.skip-link:focusstyles asindex.html, and no outline on the hero when it takes focus from the link.decision-curve-analysis-by-group.test_every_page_starts_with_a_skip_link_to_the_contentbuilds the fixture site and checks that the first focusable element is the skip link and that its target exists. It fails without the change.Checks:
tests/test_build_explainers.py26 passed,ruff check,check_em_dash.pyandcheck_generated_files_current.pypass.grep -L skip-link explainers/*.html | wc -lprints 0.Linked issue
Closes #1170