Repository navigation
fix(tooling): handle missing node in generate_key_fold.py - #990
Merged
yakew7 merged 1 commit intoOct 14, 2026
Merged
Conversation
Fixes yakew7#982 - Skip --check mode with exit 0 and notification when node is missing - Add --require flag to enforce failure when node is missing - Pass --require in CI key-normalisation workflow step - Keep failure in table rewrite mode - Add unit tests for missing node and per-test skip for node requirements
Enard52
requested review from
ahmdkaml,
propcgamer20-png and
yakew7
as code owners
October 14, 2026 16:29
Contributor
|
@Enard52 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@yakew7 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review. |
|
Hey @Enard52, your first PR on Fair Code, that's awesome, thank you. This project is about making AI more accountable, and contributions like yours are what keep that work going. We'll review your changes shortly. If you haven't already, give the contributing guide a quick read: it covers how audits are structured and what we look for in a review. And if you're finding Fair Code useful or interesting, a star on the repo genuinely helps more people find it - no pressure, just appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gracefully skips
scripts/generate_key_fold.py --checkwhen Node is missing unless--requireis passed, avoiding tracebacks on environments without Node installed.Type
Linked issue
Closes #982
Details
scripts/generate_key_fold.py:--checkmode, checks ifshutil.which("node")is available. If missing, printsnode is needed for this check (install Node 18+); skippingand exits0(or2if--requireis passed).--requireflag to enforce hard failure in CI where Node is guaranteed to be set up.subprocess.run(["node", ...])without--checkcontinues to raiseFileNotFoundError)..github/workflows/audits.yml:python scripts/generate_key_fold.py --check --requireto preserve strict CI verification.tests/test_generate_key_fold.py:@needs_nodedecorator for tests that explicitly require Node execution.--checkwith clearedPATH(exiting 0),--check --requirewith clearedPATH(exiting 2), and rewrite mode with clearedPATH(raising error).