Skip to content

fix: extend check_issue_refs.py to CONTRIBUTORS.md and METRICS.md (#981) - #991

Merged
yakew7 merged 1 commit into
yakew7:mainfrom
Enard52:fix/check-issue-refs-contributors-metrics-981
Oct 14, 2026
Merged

fix: extend check_issue_refs.py to CONTRIBUTORS.md and METRICS.md (#981)#991
yakew7 merged 1 commit into
yakew7:mainfrom
Enard52:fix/check-issue-refs-contributors-metrics-981

Conversation

@Enard52

@Enard52 Enard52 commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Summary

Resolves #981.

Extends scripts/check_issue_refs.py to cover issue references in CONTRIBUTORS.md and METRICS.md:

  • CONTRIBUTORS.md: extends the changelog rule so that every closing issue #N or closing #N claim names an issue that is closed.
  • METRICS.md: checks that every #N mentioned in sweep notes (lines starting with > ...) refers to an existing issue or pull request.
  • load_states(): queries both gh issue list and gh pr list (with fallback to offline skip unless --require is passed), ensuring PR numbers mentioned in sweep notes are recognised.
  • Added comprehensive unit tests in ests/test_check_issue_refs.py testing check_contributors() and check_metrics().
  • Updated permissions in .github/workflows/lint.yml to include pull-requests: read.

Verification

  • Ran all unit tests in ests/test_check_issue_refs.py (all 7 tests passed).
  • Ran python scripts/check_issue_refs.py against the repository with live gh (all 986 issues and PRs validated across ROADMAP.md, CHANGELOG.md, CONTRIBUTORS.md, and METRICS.md with 0 errors).
  • Ran scripts/check_em_dash.py and scripts/check_broken_links.py (both passed cleanly).

@Enard52
fix: extend check_issue_refs.py to CONTRIBUTORS.md and METRICS.md (ya…
430db75 
…kew7#981)

- check 'closing issue #N' / 'closing #N' in CONTRIBUTORS.md (must be closed)
- check that '#N' in METRICS.md sweep notes are existing issues or pull requests
- load PRs alongside issues when querying gh
- add unit tests in tests/test_check_issue_refs.py
@vercel

vercel Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

@Enard52 is attempting to deploy a commit to the yashkewlani2020-gmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions

github-actions Bot commented Oct 14, 2026

Copy link
Copy Markdown

@yakew7 @ahmdkaml @propcgamer20-png - new PR touching a path you own, please review.

@yakew7

yakew7 commented Oct 14, 2026

Copy link
Copy Markdown
Owner

@Enard52 fix the CI failing pls

@yakew7
yakew7 requested a balanced review from Copilot October 14, 2026 17:22
Copilot AI reviewed Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@yakew7
yakew7 merged commit 3278a73 into yakew7:main Oct 14, 2026
17 of 19 checks passed
yakew7 added a commit that referenced this pull request Oct 15, 2026
@yakew7
docs: sync changelog, roadmap, metrics and contributors after the sev…
8ee7efb 
…enth sweep

Adds the twelfth-wave changelog entries for the 19 closed issues, marks them done on the roadmap and lists the 19 new follow-ups (#992-#1010), adds Enard52 to the contributors file (#990, #991), and refreshes traction (forks 57, 86 issues closed this week).
yakew7 added a commit that referenced this pull request Oct 16, 2026
@yakew7
docs: sync changelog, roadmap, metrics and contributors after the eig…
4311839 
…hth sweep

Adds the thirteenth-wave changelog entries, marks the closed follow-ups done on the roadmap and lists the 18 new ones (#1011-#1028), refreshes the issues-closed count (104 this week) and the contributors snapshot (no pull request merged since #991).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@yakew7 yakew7 Awaiting requested review from yakew7 yakew7 is a code owner
@ahmdkaml ahmdkaml Awaiting requested review from ahmdkaml ahmdkaml is a code owner
@propcgamer20-png propcgamer20-png Awaiting requested review from propcgamer20-png propcgamer20-png is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

check_issue_refs.py does not look at CONTRIBUTORS.md or METRICS.md

3 participants

@Enard52 @yakew7