Fix/iOS value alignment - #202
Merged
Merged
Conversation
|
cc @yadaniyil please review this PR |
# Conflicts: # lib/src/tiles/platforms/ios_settings_tile.dart
With the title laid out at its full natural width, a long title left no room for the value and hid it. The title now fills the row and the value keeps its natural width, up to half the row, on one line. Adds layout tests for yako-dev#201 and yako-dev#203: values show on simple tiles, sit right next to the chevron, stay visible next to long titles, and follow RTL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Merged — thanks @mmng-a! This fixes #203 and also brings in #201. Before merging I brought the branch up to date with master (the It'll go out in 4.0.0 on pub.dev. |
This was referenced Sep 24, 2026
Contributor
|
This is now live in settings_ui 4.0.0 on pub.dev: https://pub.dev/packages/settings_ui/versions/4.0.0. Thanks again! |
iWisp360
pushed a commit
to iWisp360/flutter-settings-ui
that referenced
this pull request
Sep 30, 2026
- Fall back to the Cupertino style for platforms that only exist in Flutter forks, so the package compiles on OpenHarmony (yako-dev#205) - README: SettingsTile shows a value without a chevron (yako-dev#204), the navigation chevron is iOS/macOS/Windows only, value width on iOS - CHANGELOG: yako-dev#201, yako-dev#202, yako-dev#203, yako-dev#204, yako-dev#205 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
iWisp360
pushed a commit
to iWisp360/flutter-settings-ui
that referenced
this pull request
Sep 30, 2026
…the docs - 3.x never upper-cased iOS headers; apps passed ALL-CAPS titles. - Breaking changes: Linux tests must find AdwaitaSettingsSwitch, and the default side padding follows the list's width. - Credit yako-dev#207 and yako-dev#201/yako-dev#202, link the old macOS, Windows and iPad requests. - Documentation: the README rewrite, llms.txt and AGENTS.md. Example app: the showcase screen, and `cd example` before --route. - The date stays Unreleased until the day of publishing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
No related issues.
This PR is based on #201 as the base branch.
Testing and Review Notes
This PR updates the iOS value layout for
SettingsTilewhenvalueis shown.In the iOS example screen, the most visible changes are:
Commonsection (Language,Environment,Platform) now show their values clearly right-alignedEmailrow in theAccountsection now shows a long value and truncates it with ellipsis correctlyBefore this change, the
Emailvalue was not shown on iOS in this example. After this change, it is shown and truncated correctly when long.Review steps:
example/.Commonsection, confirm that the values forLanguage,Environment, andPlatformare visually right-aligned.Accountsection, confirm that theEmailrow displays the value on iOS.Screenshots or Videos
Before and after screenshots are attached for the iOS example screen.
Please compare:
Language,Environment, andPlatformEmailvalue being displayed and truncated with ellipsisTo Do