Propagate toolkit lint and format exit codes - #147
Merged
Merged
Conversation
Co-authored-by: YvetteNikolov <48315669+YvetteNikolov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix exit code handling in lint toolkit commands
Propagate toolkit lint and format exit codes
Sep 27, 2026
YvetteNikolov
marked this pull request as ready for review
September 27, 2026 15:01
YvetteNikolov
requested review from
FreakyWizard,
JasperS20,
WybeBosch,
Yannicvanveen,
laravdiemen and
rivanuff
September 27, 2026 15:01
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Toolkit Vitest dependencies and test-script wiring are incomplete.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
This PR propagates toolkit lint/format exit codes and adds Vitest coverage for success, failure, and signal termination.
Changes:
- Propagates child-process exit codes via
process.exitCode. - Adds toolkit Vitest configuration and tests.
- Registers toolkit tests in the root Vitest suite.
| File | Description |
|---|---|
vitest.config.mjs |
Registers toolkit tests. |
packages/toolkit/vitest.config.mjs |
Adds toolkit Vitest configuration. |
packages/toolkit/tests/helpers.test.js |
Tests exit-code propagation. |
packages/toolkit/src/utils/helpers.js |
Propagates child-process exit codes. |
Moderate findings remain: declare vitest in the toolkit package and wire its test script, updating the lockfile as needed.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+4
to
+7
| test: { | ||
| globals: true, | ||
| environment: 'node', | ||
| include: [ 'tests/**/*.test.js' ], |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yard-toolkit lintandyard-toolkit formatpreviously logged child-process failures but still exited successfully, preventing reliable CI and pre-commit checks.process.exitCode.code === null) as exit code1.